fix: rm notification default timeout #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 11 11
Lines 388 388
Branches 53 62 +9
=======================================
Hits 383 383
Misses 5 5
Continue to review full report at Codecov.
|
zcstarr
force-pushed
the
fix/notification-timeout
branch
from
d47e58a
to
accbf80
Compare
shanejonas
approved these changes
Dec 16, 2020
This fix was needed because the old default used undefined, which in turn triggered the default timeout when left unspecified, but would not allow the user to disable timeouts. This refactor allows users to be specific about what they want specifying default(undefined),custom timeout, or no timeout (null). fixes #231
zcstarr
force-pushed
the
fix/notification-timeout
branch
from
accbf80
to
c79d213
Compare
|
🎉 This PR is included in version 1.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #231