Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rm notification default timeout #232

Merged
merged 2 commits into from
Dec 17, 2020
Merged

fix: rm notification default timeout #232

merged 2 commits into from
Dec 17, 2020

Commits on Dec 16, 2020

  1. fix: this corrects default timeout to be disabled by specifing null. 

    This fix was needed because the old default used undefined, which
in turn triggered the default timeout when left unspecified, but
would not allow the user to disable timeouts. This refactor allows
users to be specific about what they want specifying default(undefined),custom
timeout, or no timeout (null).

fixes #231
    @zcstarr
    zcstarr committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c79d213 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Merge branch 'master' into fix/notification-timeout

    @shanejonas
    shanejonas committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    40688af View commit details
    Browse the repository at this point in the history