Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate DayRange select #3939

Merged

Conversation

shubhamchasing
Copy link
Contributor

@shubhamchasing shubhamchasing commented Aug 13, 2024

Description

Remove the duplicate DayRange select from the Activity(Pull request) tab

fixes: #3762

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Before

351129458-88cdc35f-8302-49c4-a78f-449d0db11ba5

After

Screenshot from 2024-08-13 19-20-03

Steps to QA

  1. Go to the workspace in mobile mode
  2. Notice, That no duplicate DayRange select in the Pull request Tab like Issues

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit a9bd331
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66bca9de3766ec00089a4cbf
😎 Deploy Preview https://deploy-preview-3939--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Copy link

netlify bot commented Aug 13, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit a9bd331
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66bca9dee7c72d0008d03dc9
😎 Deploy Preview https://deploy-preview-3939--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhamchasing shubhamchasing changed the title fix: remove duplicate date range select fix: remove duplicate DayRange select Aug 13, 2024
@shubhamchasing shubhamchasing changed the title fix: remove duplicate DayRange select fix: remove duplicate DayRange select Aug 13, 2024
@shubhamchasing shubhamchasing force-pushed the fix-remove-extra-day-range-select branch from 5970815 to 223c7e3 Compare August 13, 2024 14:32
Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shubhamchasing! 🚢

@nickytonline nickytonline added this pull request to the merge queue Aug 14, 2024
Merged via the queue into open-sauced:beta with commit 126d44f Aug 14, 2024
11 checks passed
open-sauced bot pushed a commit that referenced this pull request Aug 14, 2024
## [2.56.0-beta.3](v2.56.0-beta.2...v2.56.0-beta.3) (2024-08-14)

### 🐛 Bug Fixes

* remove duplicate `DayRange` select ([#3939](#3939)) ([126d44f](126d44f))
open-sauced bot pushed a commit that referenced this pull request Aug 14, 2024
## [2.56.0](v2.55.2...v2.56.0) (2024-08-14)

### 🍕 Features

* now workspace can be generated from repo page via SBOM ([#3938](#3938)) ([e2bd019](e2bd019))

### 🐛 Bug Fixes

* fixed contributor insight contributor grid not loading paged data ([#3945](#3945)) ([1f645ed](1f645ed))
* now the Dev Card share buttons appear on all screen sizes ([#3941](#3941)) ([5fce569](5fce569))
* remove duplicate `DayRange` select ([#3939](#3939)) ([126d44f](126d44f))
* validate user exists for `/user/<username>/card` page ([#3933](#3933)) ([9976453](9976453))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multiple DayRange in mobile Activity page
3 participants