fix: fixed dropdown styling #4077

ryandotfurrer · 2024-09-02T15:57:35Z

I decreased the size of the modal as well as the dropdown in desktop. However, I increased the size on mobile to make it more inline with the mobile styling.

fix #4063

Description

This PR fixes bug #4063 by decreasing the size of the dropdown selector on desktop. I also took it upon myself to make the mobile styles more inline by increasing the size of the mobile dropdown. You can see these changes in the video below.

Related Tickets & Documents

Fixes #4063

Mobile & Desktop Screenshots/Recordings

Watch the video I made for this fix.

Desktop

Before

After

Mobile

Before

After

Steps to QA

Visit any repo of your liking and click the "Add to workspace" button. Please check it in mobile as well.

Tier (staff will fill in)

Tier 1
Tier 2
Tier 3
Tier 4

[optional] What gif best describes this PR or how it makes you feel?

…own in add to workspace modal I decreased the size of the modal as well as the dropdown in desktop. However, I increased the size on mobile to make it more inline with the mobile styling. fix open-sauced#4063

netlify · 2024-09-02T15:57:39Z

✅ Deploy Preview for oss-insights ready!

Name	Link
🔨 Latest commit	`44986db`
🔍 Latest deploy log	https://app.netlify.com/sites/oss-insights/deploys/66d831a9d1dd5d00085b74de
😎 Deploy Preview	https://deploy-preview-4077--oss-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2024-09-02T15:57:53Z

✅ Deploy Preview for design-insights ready!

Name	Link
🔨 Latest commit	`44986db`
🔍 Latest deploy log	https://app.netlify.com/sites/design-insights/deploys/66d831a9e0016b0008fbbb1c
😎 Deploy Preview	https://deploy-preview-4077--design-insights.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

.env

remove line added in previous commit for NEXT_PUBLIC_EXP_API_URL

zeucapua

Thank you for the PR! Two things:

Please attach screenshots for visual bug fixes like these; the PR template has a section!
The mobile view uses a different component called AddToWorkspaceDrawer that requires a similar fix:

nickytonline

Going to take a peek at the fix, but just FYI the .env changes haven't been reverted yet. It still shows as a change in the PR.

ryandotfurrer · 2024-09-03T16:27:56Z

Thank you for the PR! Two things:

Please attach screenshots for visual bug fixes like these; the PR template has a section!

The mobile view uses a different component called AddToWorkspaceDrawer that requires a similar fix:

@zeucapua I am so sorry about that! I made a video but it wasn't showing up. I've fixed the PR comment to include the link to the video as well as appropriate screenshots.

The way I went about fixing this touched on the single-select component and AddToWorkspaceModal, I did not need to touch the AddToWorkspaceDrawer. Please let me know your thoughts on the fix and how you would have went about it.

nickytonline · 2024-09-03T18:22:58Z

Just rerunning the E2E tests we have a bit of flakiness in CI at the moment. 😅

nickytonline · 2024-09-03T18:28:31Z

Going to take a peek at the fix, but just FYI the .env changes haven't been reverted yet. It still shows as a change in the PR.

@ryandotfurrer, if you run git checkout beta -- .env and commit those changes to your branch and push them, the .env file will be removed from your PR.

nickytonline

Looks like I'm still seeing some issue on smaller screens. I dropped a suggestion for the fix.

components/atoms/Select/single-select.tsx

ryandotfurrer · 2024-09-03T19:09:44Z

Just rerunning the E2E tests we have a bit of flakiness in CI at the moment. 😅

We've experienced this in GIS as well, no worries 😅

ryandotfurrer · 2024-09-03T19:15:27Z

Going to take a peek at the fix, but just FYI the .env changes haven't been reverted yet. It still shows as a change in the PR.

@ryandotfurrer, if you run git checkout beta -- .env and commit those changes to your branch and push them, the .env file will be removed from your PR.

Done, ty for that! Any idea why the .env file was added in the first place? Just because I made changes to it? I made changes because Iw as trying to solve the /login issue before remembering it's an issue due to GIS.

Co-authored-by: Nick Taylor <nick@nickyt.co>

nickytonline · 2024-09-03T19:45:01Z

Going to take a peek at the fix, but just FYI the .env changes haven't been reverted yet. It still shows as a change in the PR.

@ryandotfurrer, if you run git checkout beta -- .env and commit those changes to your branch and push them, the .env file will be removed from your PR.

Done, ty for that! Any idea why the .env file was added in the first place? Just because I made changes to it? I made changes because Iw as trying to solve the /login issue before remembering it's an issue due to GIS.

It not in the gitignore for our project as it's settings for people to be able to contribute to the project, so any changes made will appear if you git add ..

Maybe longer term we could have an example file and just have a step where we ask people to copy it. Pretty low on the priority list atm though. 😅

nickytonline

Looks great in the drawer and in the modal now. Thanks @ryandotfurrer!

ryandotfurrer · 2024-09-03T19:54:36Z

Looks great in the drawer and in the modal now. Thanks @ryandotfurrer!

Thanks for the collaboration, @nickytonline! I misunderstood the ticket at first but justify-between is an obvious solution 😅

I'll ask for clarification next time if there is any area for confusion on the ticket.

zeucapua

Great job! LGTM

ryandotfurrer · 2024-09-03T20:17:18Z

Great job! LGTM

Thank you!

## [2.62.0-beta.3](v2.62.0-beta.2...v2.62.0-beta.3) (2024-09-10) ### 🐛 Bug Fixes * correct no insights message on contributor insights ([#4090](#4090)) ([49dfa03](49dfa03)) * fixed dropdown styling ([#4077](#4077)) ([4fa8b7f](4fa8b7f))

## [2.62.0](v2.61.0...v2.62.0) (2024-09-10) ### 🍕 Features * use `SplitButton` for repo page Add Workspace buttons ([#4062](#4062)) ([6cf13e6](6cf13e6)) ### 🐛 Bug Fixes * correct no insights message on contributor insights ([#4090](#4090)) ([49dfa03](49dfa03)) * fixed dropdown styling ([#4077](#4077)) ([4fa8b7f](4fa8b7f)) * use custom error component with Sentry error reporting for 500s ([#4078](#4078)) ([c3fd10e](c3fd10e))

fix(addtoworkspacemodal and single-select.tsx): reduced size of dropd…

e1dd2fb

…own in add to workspace modal I decreased the size of the modal as well as the dropdown in desktop. However, I increased the size on mobile to make it more inline with the mobile styling. fix open-sauced#4063

ryandotfurrer requested review from brandonroberts, nickytonline and zeucapua as code owners September 2, 2024 15:57

nickytonline requested changes Sep 2, 2024

View reviewed changes

.env Outdated Show resolved Hide resolved

refactor(.env): remove unnecessary line

7008be5

remove line added in previous commit for NEXT_PUBLIC_EXP_API_URL

zeucapua requested changes Sep 3, 2024

View reviewed changes

nickytonline reviewed Sep 3, 2024

View reviewed changes

Merge branch 'beta' into bug-fix_add-to-workspace-dropdown

c616940

nickytonline requested changes Sep 3, 2024

View reviewed changes

components/atoms/Select/single-select.tsx Outdated Show resolved Hide resolved

refactor(.env): remove .env file from PR

eb9b8a5

ryandotfurrer and others added 2 commits September 3, 2024 15:17

Merge branch 'beta' into bug-fix_add-to-workspace-dropdown

bdb5567

Update components/atoms/Select/single-select.tsx

87817ff

Co-authored-by: Nick Taylor <nick@nickyt.co>

nickytonline approved these changes Sep 3, 2024

View reviewed changes

zeucapua approved these changes Sep 3, 2024

View reviewed changes

nickytonline enabled auto-merge September 3, 2024 20:22

nickytonline changed the title ~~fix(addtoworkspacemodal and single-select): reduced size of dropdown in add to workspace modal~~ fix: fixed dropdown styling Sep 3, 2024

Merge branch 'beta' into bug-fix_add-to-workspace-dropdown

44986db

brandonroberts approved these changes Sep 4, 2024

View reviewed changes

nickytonline added this pull request to the merge queue Sep 4, 2024

Merged via the queue into open-sauced:beta with commit 4fa8b7f Sep 4, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixed dropdown styling #4077

fix: fixed dropdown styling #4077

ryandotfurrer commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading

zeucapua left a comment

nickytonline left a comment

ryandotfurrer commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline left a comment

ryandotfurrer commented Sep 3, 2024

ryandotfurrer commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline left a comment

ryandotfurrer commented Sep 3, 2024

zeucapua left a comment

ryandotfurrer commented Sep 3, 2024

fix: fixed dropdown styling #4077

fix: fixed dropdown styling #4077

Conversation

ryandotfurrer commented Sep 2, 2024 • edited Loading

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Desktop

Mobile

Steps to QA

Tier (staff will fill in)

[optional] What gif best describes this PR or how it makes you feel?

netlify bot commented Sep 2, 2024 • edited Loading

✅ Deploy Preview for oss-insights ready!

netlify bot commented Sep 2, 2024 • edited Loading

✅ Deploy Preview for design-insights ready!

zeucapua left a comment

Choose a reason for hiding this comment

nickytonline left a comment

Choose a reason for hiding this comment

ryandotfurrer commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline left a comment

Choose a reason for hiding this comment

ryandotfurrer commented Sep 3, 2024

ryandotfurrer commented Sep 3, 2024

nickytonline commented Sep 3, 2024

nickytonline left a comment

Choose a reason for hiding this comment

ryandotfurrer commented Sep 3, 2024

zeucapua left a comment

Choose a reason for hiding this comment

ryandotfurrer commented Sep 3, 2024

ryandotfurrer commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading

netlify bot commented Sep 2, 2024 •

edited

Loading