Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Upload Schema to Multiple Components #35

Merged
merged 21 commits into from
Sep 3, 2020

Conversation

serenackuo
Copy link
Contributor

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Convert single modal panel of upload schema/input schema code into multiple-stage modal housing multiple components
  • Add Readme and License

Approach

  • Added multiple components to house within the modal
  • Use react router to load different components within modal window
  • Reconfigure component tree to respond to revised interface structure
  • Write Readme.md with full markdown
  • Compile error on "Link To" within SchemaModal - but non-code-breaking

Screenshot(s)

Screen Shot 2020-09-03 at 12 37 35 AM

Screen Shot 2020-09-03 at 12 37 53 AM

Copy link
Member

@mstronck mstronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new look. There is an error whenever we load up the app, but nothing we don't know about and nothing breaking.

Copy link
Contributor

@catherinechiu catherinechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing readme 👍

@catherinechiu catherinechiu merged commit d252718 into open-source-labs:staging Sep 3, 2020
frakes413 pushed a commit to frakes413/SeeQR that referenced this pull request Oct 10, 2020
cindychau pushed a commit that referenced this pull request Feb 25, 2021
JBradbeer pushed a commit that referenced this pull request Apr 28, 2022
Frynoceros pushed a commit that referenced this pull request Aug 4, 2022
derekoko pushed a commit that referenced this pull request Aug 24, 2023
minor changes while working on tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants