Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boilerplate #6

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Boilerplate #6

merged 6 commits into from
Aug 17, 2020

Conversation

serenackuo
Copy link
Contributor

@serenackuo serenackuo commented Aug 17, 2020 •
edited by rlam108
Loading

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Enable hot reloading in dev environment, typescript compiling, build webpack bundle
  • Load splash window upon app launch

Approach

  • Combined webpack.config to be more streamlined
  • Incorporate typescript transpiler as a part of run dev script

Learning

  • Reference webpack, electron, typescript documentation, other open source projects as case studies

Screenshot(s)

Screen Shot 2020-08-17 at 1 54 50 PM

mstronck
mstronck approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@mstronck mstronck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome additions! Great work :)

catherinechiu
catherinechiu approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@catherinechiu catherinechiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@catherinechiu catherinechiu merged commit 7d6199b into open-source-labs:staging Aug 17, 2020
frakes413 pushed a commit to frakes413/SeeQR that referenced this pull request Oct 1, 2020
@caseyescovedo
Merge pull request open-source-labs#6 from oslabs-beta/staging
d9abe67 
Frontend testing and live sass compiler bug fix
chrisakinrinade pushed a commit that referenced this pull request Jan 7, 2021
@kklochan
Merge pull request #6 from jcourtner/remove-docker-dummy
af822f5 
Updated dummyDataMain
cindychau pushed a commit that referenced this pull request Feb 25, 2021
@FarazA22
Merge pull request #6 from rlam108/master
001be25 
refactored files in leftPanel folder based on eslint
JBradbeer pushed a commit that referenced this pull request Apr 28, 2022
@santosb93
Merge pull request #6 from oslabs-beta/bryan/deletecolumn
8f5318d 
Bryan/deletecolumn
Frynoceros pushed a commit that referenced this pull request Aug 4, 2022
@fred-jeong
Merge pull request #6 from oslabs-beta/ian/fix-missing-types
be94a91 
Ian/fix missing types
Hiya-its-Aya pushed a commit that referenced this pull request Feb 23, 2023
@utyvert
Merge pull request #6 from oslabs-beta/trev
557c117 
setSelectedView working from help modal
junaid-ahmed7 added a commit that referenced this pull request Apr 20, 2023
@junaid-ahmed7
Merge pull request #6 from oslabs-beta/junaid-fixingBackend
677aad5 
added error handling and sending error messages to the frontend for u…
haemie added a commit that referenced this pull request Jul 7, 2023
@haemie
Merge pull request #6 from oslabs-beta/feature/HideSbBtn
7da101a 
Updated dependencies and fixed hide sidebar button
derekoko added a commit that referenced this pull request Aug 24, 2023
@derekoko
Merge pull request #6 from oslabs-beta/minor-import-and-linter-tweaks
59e4bd2 
Minor import and linter tweaks (and electron25)
lovelyjoy1991 added a commit that referenced this pull request Jun 5, 2024
@lovelyjoy1991
Merge pull request #6 from oslabs-beta/devof/dev
b65c600 
`fix` backend and frontend tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catherinechiu catherinechiu catherinechiu approved these changes

@mstronck mstronck mstronck approved these changes

@FrankNorton32 FrankNorton32 Awaiting requested review from FrankNorton32

@muhammadtrad muhammadtrad Awaiting requested review from muhammadtrad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serenackuo @catherinechiu @mstronck @muhammadtrad