Skip to content

Commit

Permalink
[exporter/signalfx] update translation rule to use a copy of system.c…
Browse files Browse the repository at this point in the history
…pu.time & system.paging.operations and leave the original one intact (#19743)

[exporter/signalfx] update translation rule to use a copy of system.cpu.time and leave the original one intact

Signed-off-by: Dani Louca <dlouca@splunk.com>
  • Loading branch information
dloucasfx authored Mar 18, 2023
1 parent 2417c3e commit 6b0c2cc
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
16 changes: 16 additions & 0 deletions .chloggen/sfx-exporter-translation-rule.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: signalfxexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: use a copy of system.cpu.time and system.paging.operations when splitting the metric, this will allow the user to send the original metric

# One or more tracking issues related to the change
issues: [19743]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
12 changes: 10 additions & 2 deletions exporter/signalfxexporter/internal/translation/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,11 @@ translation_rules:
sf_temp.cpu.utilization: 100
# convert cpu metrics
- action: copy_metrics
mapping:
system.cpu.time: sf_temp.system.cpu.time
- action: split_metric
metric_name: system.cpu.time
metric_name: sf_temp.system.cpu.time
dimension_key: state
mapping:
idle: sf_temp.cpu.idle
Expand Down Expand Up @@ -369,8 +372,11 @@ translation_rules:
sf_temp.memory.utilization: 100
# Virtual memory metrics
- action: copy_metrics
mapping:
system.paging.operations: sf_temp.system.paging.operations
- action: split_metric
metric_name: system.paging.operations
metric_name: sf_temp.system.paging.operations
dimension_key: direction
mapping:
page_in: sf_temp.system.paging.operations.page_in
Expand Down Expand Up @@ -448,9 +454,11 @@ translation_rules:
sf_temp.memory.used: true
sf_temp.system.cpu.delta: true
sf_temp.system.cpu.total: true
sf_temp.system.cpu.time: true
sf_temp.system.cpu.usage: true
sf_temp.system.filesystem.usage: true
sf_temp.system.memory.usage: true
sf_temp.system.paging.operations: true
sf_temp.system.paging.operations.page_in: true
sf_temp.system.paging.operations.page_out: true
`

0 comments on commit 6b0c2cc

Please sign in to comment.