Skip to content

Commit

Permalink
[exporter/jaeger] do not expose method (#26466)
Browse files Browse the repository at this point in the history
**Description:**
Remove exposed function, only keep NewFactory to pass checkapi

**Link to tracking Issue:**

#26304
  • Loading branch information
sakulali authored Sep 6, 2023
1 parent 854550b commit f85204a
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 4 deletions.
27 changes: 27 additions & 0 deletions .chloggen/jaeger-checkapi.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: jaegerexporter

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Do not export the function `MetricViews`

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [26304]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
1 change: 0 additions & 1 deletion cmd/checkapi/allowlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exporter/coralogixexporter
exporter/dynatraceexporter
exporter/elasticsearchexporter
exporter/f5cloudexporter
exporter/jaegerexporter
exporter/kafkaexporter
exporter/loadbalancingexporter
exporter/logzioexporter
Expand Down
4 changes: 2 additions & 2 deletions exporter/jaegerexporter/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ var (
}
)

// MetricViews return the metrics views according to given telemetry level.
func MetricViews() []*view.View {
// metricViews return the metrics views according to given telemetry level.
func metricViews() []*view.View {
return []*view.View{vLastConnectionState}
}
2 changes: 1 addition & 1 deletion exporter/jaegerexporter/metrics_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func TestProcessorMetrics(t *testing.T) {
"jaegerexporter_conn_state",
}

views := MetricViews()
views := metricViews()
for i, viewName := range expectedViewNames {
assert.Equal(t, viewName, views[i].Name)
}
Expand Down

0 comments on commit f85204a

Please sign in to comment.