Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/jaeger] do not expose method #26466

Merged
merged 3 commits into from
Sep 6, 2023
Merged

[exporter/jaeger] do not expose method #26466

merged 3 commits into from
Sep 6, 2023

Conversation

sakulali
Copy link
Contributor

@sakulali sakulali commented Sep 5, 2023

Description:
Remove exposed function, only keep NewFactory to pass checkapi

Link to tracking Issue:
#26304

@sakulali sakulali requested a review from jpkrohling as a code owner September 5, 2023 14:36
@sakulali sakulali requested a review from a team September 5, 2023 14:36
@github-actions github-actions bot requested a review from frzifus September 5, 2023 14:37
@jpkrohling jpkrohling merged commit f85204a into open-telemetry:main Sep 6, 2023
90 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2023
@sakulali sakulali deleted the fix-jaegerexporter-api branch September 26, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@frzifus frzifus Awaiting requested review from frzifus

Assignees

@dmitryax dmitryax

Labels
exporter/jaeger
Projects
None yet
Milestone
v0.85.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sakulali @jpkrohling @dmitryax