Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SASL/SCRAM authentication to Kafka receiver and exporter #5009

Closed
altieresfreitas opened this issue Dec 4, 2020 · 3 comments
Closed

Add SASL/SCRAM authentication to Kafka receiver and exporter #5009

altieresfreitas opened this issue Dec 4, 2020 · 3 comments
Labels
comp:kafka Kafka related issues

Comments

@altieresfreitas
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I would like to use SASL/SCRAM authentication mechanism on kafka receiver and exporter.
The current authentication mechanisms implemented on collector are not supported by AWS MSK

Describe the solution you'd like

SASL/SCRAM authentication mechanism is already supported by sarama, the library used by collector.
We could implement this on authentication.go using the same library, adding a SCRAMConfig struct and a new function to configure SCRAM.

Describe alternatives you've considered
None.
Additional context
None.
@bogdandrutu bogdandrutu transferred this issue from open-telemetry/opentelemetry-collector Aug 30, 2021
@alolita alolita added the comp:kafka Kafka related issues label Sep 2, 2021
@MovieStoreGuy
Copy link
Contributor

Hey @altieresfreitas ,

I believe you're referring to IBM/sarama#1985 ?

@MovieStoreGuy MovieStoreGuy mentioned this issue Oct 15, 2021
Merged
tigrannajaryan pushed a commit that referenced this issue Oct 26, 2021
@MovieStoreGuy
kafkaexporter: Add support for AWS_MSK_IAM SASL Auth (#5763)
67e165e 
This allows for developers to use this the existing kafka exporter and use the newly minted AWS_MSK_IAM SASL auth.

**Link to tracking Issue:** #5009
In a very loose definition of related ticket.

**Testing:**
I have some rather basic testing locally to see what I can get done with this.
I had followed https://github.com/aws/aws-msk-iam-auth#details as close as I could with this.

**Documentation:**
I haven't added any new documentation for this since I hadn't have the chance to actually validate this in a production like setting so I am hoping to leave it as a dark feature for the time being.
@MovieStoreGuy
Copy link
Contributor

Hey @alolita ,

This work as been done (see https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/exporter/kafkaexporter/authentication.go#L43)

@Neustradamus
Copy link

It has been added here, time to close this PR ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:kafka Kafka related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SASL_SCRAM authentication mechanism on kafka exporter altieresfreitas/opentelemetry-collector
5 participants
@jpkrohling @Neustradamus @alolita @altieresfreitas @MovieStoreGuy