kafkaexporter: Add support for AWS_MSK_IAM SASL Auth #5763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MovieStoreGuy
force-pushed
the
smarciniak/add-initial-awsmskexporter
branch
from
1d86d7a to
99f868c
Compare
anuraaga
reviewed
Oct 15, 2021
Aneurysm9
reviewed
Oct 15, 2021
MovieStoreGuy
force-pushed
the
smarciniak/add-initial-awsmskexporter
branch
from
88102f6 to
ff25d82
Compare
anuraaga
approved these changes
Oct 18, 2021
anuraaga
reviewed
Oct 18, 2021
jcmackie
reviewed
Oct 18, 2021
MovieStoreGuy
force-pushed
the
smarciniak/add-initial-awsmskexporter
branch
3 times, most recently
from
2a748e2 to
55061c3
Compare
|
@bogdandrutu , @tigrannajaryan , Could I please get this merged in? |
|
@MovieStoreGuy sorry, needs a rebase again. Once you do it ping me directly so that I can merge. If it stays open there is a chance go.sum will conflict again. |
|
No worries, let me resolve this and I shall get back to you. |
added 9 commits
October 26, 2021 11:59
I have roughly worked through and figured out what needs to be done to support this, however it is currently untested in production so should be clear is a beta feature.
- Tidy up of over eager human optimisation - Updated config
MovieStoreGuy
force-pushed
the
smarciniak/add-initial-awsmskexporter
branch
from
55061c3 to
c3ed66d
Compare
|
@tigrannajaryan, would you mind merging? |
datsabk
added a commit
to datsabk/opentelemetry-collector-contrib
that referenced
this pull request
Mar 14, 2023
Updated documentation to reflect the changes made in (this PR)[open-telemetry#5763]
djaglowski
pushed a commit
that referenced
this pull request
Mar 17, 2023
Update README.md Updated documentation to reflect the changes made in (this PR)[#5763]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This allows for developers to use this the existing kafka exporter and use the newly minted AWS_MSK_IAM SASL auth.
Link to tracking Issue: #5009
In a very loose definition of related ticket.
Testing:
I have some rather basic testing locally to see what I can get done with this.
I had followed https://github.com/aws/aws-msk-iam-auth#details as close as I could with this.
Documentation:
I haven't added any new documentation for this since I hadn't have the chance to actually validate this in a production like setting so I am hoping to leave it as a dark feature for the time being.