Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert usage of ${env:ENV} style syntax in examples #17546

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 12, 2023

Description:

Partial revert of #17300 because of open-telemetry/opentelemetry-collector/issues/6932

Link to tracking Issue: Relates to open-telemetry/opentelemetry-collector/issues/6932 and #17299

@mx-psi mx-psi requested a review from a team January 12, 2023 16:39
@mx-psi mx-psi changed the title Partially revert usage of style syntax in examples Partially revert usage of ${env:ENV} style syntax in examples Jan 12, 2023
@runforesight
Copy link

runforesight bot commented Jan 12, 2023

Foresight Summary

    
Major Impacts

TestReceiveBatchedMetrics ❌ failed 1 times in 3 runs (33% fail rate).
TestReceiveBatchedMetrics/2_metric_events_per_payload_(configured_max_content_length_is_twice_event_size) ❌ failed 1 times in 3 runs (33% fail rate).
build-and-test-windows duration(4 seconds) has decreased 44 minutes 6 seconds compared to main branch avg(44 minutes 10 seconds).
View More Details

✅  tracegen workflow has finished in 2 minutes 10 seconds and finished at 12th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 3 minutes and finished at 12th Jan, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 4 minutes 44 seconds (⚠️ 2 minutes 42 seconds more than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 6 minutes 13 seconds (1 minute 55 seconds less than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 11 minutes 18 seconds (3 minutes 54 seconds less than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details

⭕  changelog workflow has finished in 5 seconds (2 minutes 10 seconds less than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 4 seconds (44 minutes 6 seconds less than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  build-and-test workflow has finished in 32 minutes 16 seconds (17 minutes 7 seconds less than main branch avg.) and finished at 12th Jan, 2023.


Job Failed Steps Tests
unittest-matrix (1.18, exporter) -     🔗  ✅ 2464  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4438  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4438  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1884  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1884  ❌ 0  ⏭ 0    🔗 See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 12, 2023
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think config sources are expected to be interpolated inside strings.

@codeboten codeboten merged commit 98368b6 into open-telemetry:main Jan 12, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Jan 13, 2023

I don't think config sources are expected to be interpolated inside strings.

It's not supported today, but let's discuss if it should be over at open-telemetry/opentelemetry-collector/issues/6932 :)

@mx-psi mx-psi deleted the mx-psi/partial-revert-17300 branch January 13, 2023 08:44
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/datadog Datadog components exporter/sapm extension/basicauth receiver/kubeletstats receiver/prometheus Prometheus receiver Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants