Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Use new ${env:ENV} style syntax in examples #17299

Closed
mx-psi opened this issue Dec 29, 2022 · 4 comments · Fixed by #17300 or #20737
Closed

[docs] Use new ${env:ENV} style syntax in examples #17299

mx-psi opened this issue Dec 29, 2022 · 4 comments · Fixed by #17300 or #20737
Assignees
@mx-psi
Labels
chore documentation Improvements or additions to documentation

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 29, 2022

Component(s)

No response

Describe the issue you're reporting

Since open-telemetry/opentelemetry-collector/pull/6276 we support and encourage using ${env:ENV} style syntax for expanding environment variables in configuration. This syntax is aligned with the expand feature as opposed to the old $ENV syntax.

This issue tracks updating documentation and examples in contrib to the new syntax.
@mx-psi mx-psi added documentation Improvements or additions to documentation chore labels Dec 29, 2022
@mx-psi mx-psi self-assigned this Dec 29, 2022
This was referenced Dec 29, 2022
Merged
Merged
Merged
This was referenced Jan 12, 2023
Merged
Merged
@mx-psi
Copy link
Member Author

mx-psi commented Jan 12, 2023

Reopening because of #17546

@mx-psi mx-psi reopened this Jan 12, 2023
@mx-psi mx-psi added the on hold This is blocked by another PR/issue label Jan 12, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Jan 31, 2023

open-telemetry/opentelemetry-collector/issues/6932 was fixed, will wait until v0.71.0 is out to fix the examples

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Apr 3, 2023
@mx-psi mx-psi removed Stale on hold This is blocked by another PR/issue labels Apr 3, 2023
@mx-psi
Copy link
Member Author

mx-psi commented Apr 3, 2023

Not on hold anymore, but still an issue :)

@codeboten codeboten mentioned this issue Apr 6, 2023
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector-contrib that referenced this issue Apr 21, 2023
[chore] update usage of env var
c5a6902 
Fixes open-telemetry#17299

Signed-off-by: Alex Boten <aboten@lightstep.com>
mx-psi pushed a commit that referenced this issue Apr 21, 2023
[chore] update usage of env var (#20737)
a6c7576 
* [chore] update usage of env var

Fixes #17299

Signed-off-by: Alex Boten <aboten@lightstep.com>

* apply review feedback

Signed-off-by: Alex Boten <aboten@lightstep.com>

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
@mx-psi mx-psi mentioned this issue Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mx-psi mx-psi

Labels
chore documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
1 participant
@mx-psi