Use ${env:ENV} style syntax when getting environment variables

[mx-psi]

The OpenTelemetry Collector supports both the legacy ${ENV} syntax as well as the new ${env:ENV} syntax (enabled by default since v0.62.0, see open-telemetry/opentelemetry-collector@b15179e, fully working for the use case of this Helm chart since v0.71.0, see open-telemetry/opentelemetry-collector@202c030). The latter is preferred and we have updated examples in the OpenTelemetry Collector repository to use it (see open-telemetry/opentelemetry-collector-contrib/issues/17299).

The Helm chart uses the legacy syntax since #603, see

opentelemetry-helm-charts/charts/opentelemetry-collector/values.yaml

Lines 82 to 96 in 7252934

	receivers:
	jaeger:
	protocols:
	grpc:
	endpoint: ${MY_POD_IP}:14250
	thrift_http:
	endpoint: ${MY_POD_IP}:14268
	thrift_compact:
	endpoint: ${MY_POD_IP}:6831
	otlp:
	protocols:
	grpc:
	endpoint: ${MY_POD_IP}:4317
	http:
	endpoint: ${MY_POD_IP}:4318

We should use the new ${env:ENV} style syntax here instead. Note that this would break users of the Collector < v0.71.0 (not sure how this is handled in the Helm chart, but we may want to wait a bit).

[JaredTan95]

I'd like to update this, pls assign it to me :-P