[opentelemetry-collector] update MY_POD_IP with ${env:MY_POD_IP}

[JaredTan95]

close #761

[Allex1]

@JaredTan95 this seems like a breaking change so can you pls bump the minor version of the chart and update the docs ?

[JaredTan95]

this seems like a breaking change

Sorry, I don't understand why it's a breaking change. Can you tell me about it? thx~

[Allex1]

Sorry, I don't understand why it's a breaking change. Can you tell me about it? thx~

Reading #761 seems that ${env:ENV} syntax is not supported before collector 0.71 . We may have users of this helm chart that overwrite the older version of the collector right ?
I would make it clear that it will not work in that case. wdyt ?

[povilasv]

Probably in this case it's better to be safe than sorry, so let's bump the minor version and add some note in https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/charts/opentelemetry-collector/UPGRADING.md :)

[JaredTan95]

@Allex1 @povilasv thx, got you~

[dmitryax]

Reading #761 seems that ${env:ENV} syntax is not supported before collector 0.71 . We may have users of this helm chart that overwrite the older version of the collector right ?

0.71.0 got only a fix that is unrelated to our use cases. ${env:...} syntax has been supported for long time. I belive it was added in 2021 :) Not sure we really need the upgrade guidelines

[mx-psi]

Reading #761 seems that ${env:ENV} syntax is not supported before collector 0.71 . We may have users of this helm chart that overwrite the older version of the collector right ?

0.71.0 got only a fix that is unrelated to our use cases. ${env:...} syntax has been supported for long time. I belive it was added in 2021 :) Not sure we really need the upgrade guidelines

The ${env:ENV} syntax has been supported since v0.62.0 (October 2022). It was available under a feature gate before, but it was disabled by default.

The fix in v0.71.0 (February 2023) is necessary for all the usages here to work properly; before v0.71.0 every single usage on the Helm chart will silently fail to expand.

[TylerHelmuth]

@mx-psi thanks for the details. @JaredTan95 sorry, but would you be willing to submit another PR touching up the UPGRADING doc saying that using chart version 0.55.1 or higher requires a collector version 0.71.0 or higher?

[dmitryax]

Oh, @mx-psi is right. I am sorry for causing the confusion!