Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Migrate jmx receiver integration test #23066

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Jun 5, 2023

This also includes the addition of another option, AllowHardcodedHostPort, which allows exposed ports to be hardcoded. Generally this is not ideal practice, so it's worthwhile to reject it when possible. However, exposing a JMX port outside of the container is apparently difficult or impossible, unless hardcoded.

Resolves #23187

@github-actions github-actions bot requested a review from rmfitzpatrick June 5, 2023 17:21
@djaglowski djaglowski marked this pull request as ready for review June 5, 2023 18:18
@djaglowski djaglowski requested review from a team and dmitryax June 5, 2023 18:18
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to move some plain strings and values into central variables and move some of the re-usable test setup into separate functions to make it easier to add more tests in the future. I realize this is mostly just moving things around though, so it's not necessary as a part of this change.

@dmitryax
Copy link
Member

dmitryax commented Jun 6, 2023

Will this potentially resolve #23187 ?

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jun 6, 2023
@djaglowski
Copy link
Member Author

@dmitryax, I forgot to note it but I believe it will.

@TylerHelmuth TylerHelmuth merged commit 8dc41a8 into open-telemetry:main Jun 7, 2023
@github-actions github-actions bot added this to the next release milestone Jun 7, 2023
@djaglowski djaglowski deleted the jmx-inttest-port branch June 7, 2023 15:17
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal/core ready to merge Code review completed; ready to merge by maintainers receiver/jmx JMX Receiver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/jmx] Flaky test TestJMXIntegration/TestJMXReceiverHappyPath
6 participants