Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[exporter/datadog] Add telemetry metric for runtime metrics #23138

Merged
merged 9 commits into from
Jun 9, 2023
Merged

[exporter/datadog] Add telemetry metric for runtime metrics #23138

merged 9 commits into from
Jun 9, 2023

Conversation

liustanley
Copy link
Contributor

Description:

Adds metric otel.datadog_exporter.runtime_metrics.running to track when the exporter receives a payload containing runtime metrics.

Link to tracking Issue:

Testing:

Documentation:

@github-actions github-actions bot added the exporter/datadog Datadog components label Jun 5, 2023
@github-actions github-actions bot requested review from dineshg13, gbbr, mx-psi and songy23 June 5, 2023 20:08
songy23
songy23 reviewed Jun 6, 2023
View reviewed changes
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a changelog

@liustanley liustanley changed the title [exporter/datadogexporter] Add telemetry metric for runtime metrics [exporter/datadog] Add telemetry metric for runtime metrics Jun 6, 2023
@liustanley liustanley marked this pull request as ready for review June 6, 2023 20:40
@liustanley liustanley requested review from a team, gbbr and songy23 June 6, 2023 20:40
gbbr
gbbr approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Stanley! Approving as far as my comments go. Please address @songy23's too before merging.

@songy23
Copy link
Member

songy23 commented Jun 7, 2023

build-and-test / integration-tests should be fixed with #23066. Please merge main

@liustanley liustanley requested a review from songy23 June 8, 2023 16:27
@liustanley @songy23
Update exporter/datadogexporter/internal/metrics/consumer.go
f842537 
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jun 8, 2023
@mx-psi mx-psi merged commit b3c16b9 into open-telemetry:main Jun 9, 2023
@github-actions github-actions bot added this to the next release milestone Jun 9, 2023
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
@liustanley @songy23 @Caleb-Hurshman
[exporter/datadog] Add telemetry metric for runtime metrics (open-tel…
3fc35fa 
…emetry#23138)

* Add telemetry metric

* Change DefaultMetrics function signature

* Update metadata type

* Update test

* Add changelog

* PR comments

* Update exporter/datadogexporter/internal/metrics/consumer.go

Co-authored-by: Yang Song <songy23@users.noreply.github.com>

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songy23 songy23 songy23 approved these changes

@gbbr gbbr gbbr approved these changes

@dineshg13 dineshg13 Awaiting requested review from dineshg13

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.80.0
Development

Successfully merging this pull request may close these issues.
5 participants
@liustanley @songy23 @gbbr @mx-psi @MovieStoreGuy