[resourcedetectionprocessor] Add task revision to ECS resource detector #2814
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2814 +/- ##
=======================================
Coverage 91.57% 91.57%
=======================================
Files 447 447
Lines 22077 22078 +1
=======================================
+ Hits 20216 20217 +1
Misses 1392 1392
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -65,6 +65,7 @@ ec2: | |||
| * aws.ecs.cluster.arn | |||
| * aws.ecs.task.arn | |||
| * aws.ecs.task.family | |||
| * aws.ecs.task.revision | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
| attr.InsertString("aws.ecs.task.arn", tmdeResp.TaskARN) | ||
| attr.InsertString("aws.ecs.task.family", tmdeResp.Family) | ||
| attr.InsertString("aws.ecs.task.revision", tmdeResp.Revision) |
There was a problem hiding this comment.
Please define these in go.opentelemetry.io/collector/translator/conventions
There was a problem hiding this comment.
open-telemetry/opentelemetry-collector#2816, waiting on the spec PR to mark as ready. I will do a PR to update all these strings once that is merged
…or (#2814) Add task `Revision` field, defined as > The revision of the Amazon ECS task definition for the task. It is available in both the [v3](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v3.html) and [v4](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-metadata-endpoint-v4.html) endpoints. **Link to tracking Issue:** n/a **Testing:** Updated unit tests. **Documentation:** Added to README
Description:
Add task
Revisionfield, defined asIt is available in both the v3 and v4 endpoints.
Link to tracking Issue: n/a
Testing: Updated unit tests.
Documentation: Added to README