Add aws.ecs.task.revision semantic convention #1581
Conversation
| type: string | ||
| brief: > | ||
| The revision for this task definition. | ||
| examples: ["8", "26"] |
There was a problem hiding this comment.
If these are integer counters that get incremented for each revision, please use the integer type.
If the revision could be non-integer as well (e.g. "8b"), please add an example to make this clear.
Thanks!
There was a problem hiding this comment.
The endpoint returns a string but that string can be usually (maybe always?) parsed as an integer. AWS' docs only exemplify that the type returned is a string but they don't clarify if it's always an integer.
I think it's better to use a string in case something like 8b can be returned by the endpoint (either now or in the future), but I don't feel comfortable adding it as an example since I have not seen that happen in practice and no similar example exists in the docs.
There was a problem hiding this comment.
We should stick with string if that's the type in the API docs I think
There was a problem hiding this comment.
Alright! If we can't tell if it could be any string other than one resembling an integer I'm fine with also keeping the examples as is.
Changes
Add semantic convention for an ECS task definition revision, described in the AWS ECS Task metadata endpoint documentation as
Follow up to open-telemetry/opentelemetry-collector-contrib#2814.