Add GOOS=windows to lint-matrix #30743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
changed the title
|
Confirmed: when the Go cache for lint is updated the step for GOOS=windows takes a bit less than the lint step with it. So until the cache is updated we should expect the step with GOOS=windows to take quite more, that, will improve after the PR is merged and the old caches get evicted. |
atoulme
approved these changes
Jan 24, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
**Description:** Add a lint step to CI with `GOOS=windows`. This will ensure that code for Windows keeps a clean lint pass. Until the lint Go cache is invalidated the step with `GOOS=windows` will be a bit longer than the Linux step. I'm measuring in my fork to see what we should expect after the cache is updated. I had an alternative implementation using Windows runners instead, but, overall it required separated Go caches and many more runners, running on Linux also ensures that the step can also be run by contributors on their dev boxes. **Link to tracking Issue:** Related to open-telemetry#11557 and open-telemetry#27866, but, it doesn't fix any of the two. **Testing:** Validated that the step is passing for all components
codeboten
pushed a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Aug 1, 2024
I'm volunteering myself to own the tier 2 support for windows/amd64. This will put the windows/amd64 on par with the other tier 2 platforms by having a specific person owning it. Some of Windows related things that I contribute(d): * Codeowner of various Windows related components in contrib (pkg/winperfcounters, activedirectorydsreceiver, iisreceiver, windowseventlogreceiver, and windowsperfcountersreceiver) * Fixing Windows related issues (e.g.: #9042, #9689, #9726, open-telemetry/opentelemetry-collector-contrib#30743) * MSI on the collector releases repo (open-telemetry/opentelemetry-collector-releases#560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a lint step to CI with
GOOS=windows. This will ensure that code for Windows keeps a clean lint pass.Until the lint Go cache is invalidated the step with
GOOS=windowswill be a bit longer than the Linux step. I'm measuring in my fork to see what we should expect after the cache is updated. I had an alternative implementation using Windows runners instead, but, overall it required separated Go caches and many more runners, running on Linux also ensures that the step can also be run by contributors on their dev boxes.Link to tracking Issue:
Related to #11557 and #27866, but, it doesn't fix any of the two.
Testing:
Validated that the step is passing for all components
Documentation:
N/A