Add a workflow to test otelcorecol as a Windows service #9689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
commented
Mar 4, 2024
Comment on lines
+42
to
+57
| - name: Checkout Repo | ||
| uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
| - name: Setup Go | ||
| uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 | ||
| with: | ||
| go-version: ~1.21.5 | ||
| cache: false | ||
| - name: Cache Go | ||
| uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0 | ||
| env: | ||
| cache-name: cache-go-modules | ||
| with: | ||
| path: | | ||
| ~\go\pkg\mod | ||
| ~\AppData\Local\go-build | ||
| key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }} |
There was a problem hiding this comment.
This seems repeated in various jobs it seems possible to put all these common steps in a shared action. I will take a look that later.
pjanotti
commented
Mar 4, 2024
Comment on lines
+67
to
+70
| - name: Test otelcorecol service | ||
| run: | | ||
| (Start-Service otelcorecol -PassThru).WaitForStatus('Running', '00:00:30') | ||
| (Stop-Service otelcorecol -PassThru).WaitForStatus('Stopped', '00:00:30') |
There was a problem hiding this comment.
When implementing #5300 I will switch this to a golang test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9689 +/- ##
=======================================
Coverage 90.90% 90.90%
=======================================
Files 348 348
Lines 18382 18382
=======================================
Hits 16710 16710
Misses 1348 1348
Partials 324 324 ☔ View full report in Codecov by Sentry. |
codeboten
pushed a commit
that referenced
this pull request
Aug 1, 2024
I'm volunteering myself to own the tier 2 support for windows/amd64. This will put the windows/amd64 on par with the other tier 2 platforms by having a specific person owning it. Some of Windows related things that I contribute(d): * Codeowner of various Windows related components in contrib (pkg/winperfcounters, activedirectorydsreceiver, iisreceiver, windowseventlogreceiver, and windowsperfcountersreceiver) * Fixing Windows related issues (e.g.: #9042, #9689, #9726, open-telemetry/opentelemetry-collector-contrib#30743) * MSI on the collector releases repo (open-telemetry/opentelemetry-collector-releases#560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding a workflow to fix #6455 this will also be needed when fixing #5300
Fixes #6455
Link to tracking Issue:
#6455