-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update New Relic exporter. #3091
Update New Relic exporter. #3091
Conversation
4185eec
to
ba310b9
Compare
Codecov Report
@@ Coverage Diff @@
## main #3091 +/- ##
==========================================
+ Coverage 91.59% 91.72% +0.13%
==========================================
Files 486 487 +1
Lines 23519 23757 +238
==========================================
+ Hits 21543 21792 +249
+ Misses 1466 1457 -9
+ Partials 510 508 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
a12dd3a
to
04b2d5b
Compare
@alanwest @a-feld @jack-berg @nrcventura please review :) |
Thanks the team is looking, I think @nrcventura was going to add a bit more code coverage! I'll push this back into draft. Sorry about the premature "ready for review" 😄 |
1b44b29
to
f121e02
Compare
Co-authored-by: Jack Berg <jberg@newrelic.com> Co-authored-by: Alan West <awest@newrelic.com> Co-authored-by: Chris Ventura <cventura@newrelic.com>
f121e02
to
4f44111
Compare
We've been discussing this PR at length within the team and we all agree that it's important to document some of the important breaking changes in this PR. 🚨 This PR drops support for cumulative metrics being sent to New Relic via a collector. 🚨 This is being done for the following reasons:
We believe that solutions exist today, such as New Relic's prometheus scraper that currently work around these issues and provide a better experience. |
@bogdandrutu This is good to go now. |
* Update New Relic exporter. Co-authored-by: Jack Berg <jberg@newrelic.com> Co-authored-by: Alan West <awest@newrelic.com> Co-authored-by: Chris Ventura <cventura@newrelic.com> * Fix lint errors. * Add missing test. * Add test coverage for api key value. * Capture headers and validate key logic. * Add unsupported metric type test. * Add attribute metadata metric * Update readme * Fix speling. * Add missing tests for metrics.go * Update go.mod * Add missing transformer.go tests * Add missing tests for newrelic.go * Fix lint error Co-authored-by: Jack Berg <jberg@newrelic.com> Co-authored-by: Alan West <awest@newrelic.com> Co-authored-by: Chris Ventura <cventura@newrelic.com> Co-authored-by: Chris Ventura <45495992+nrcventura@users.noreply.github.com> Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Description: This updates the New Relic exporter.
Changes include:
🚨 This PR drops support for cumulative metrics being sent to New Relic via a collector. 🚨
This is being done for the following reasons:
We believe that solutions exist today, such as New Relic's prometheus scraper that currently work around these issues and provide a better experience.
Testing: Updated unit tests
Documentation: Updated readme