Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(exporter/newrelicexporter/README.md): Update the new relic exporter documents #3194

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

Shihao-Zhong
Copy link
Contributor

@Shihao-Zhong Shihao-Zhong commented Apr 21, 2021

Description:

Update the new relic exporter's config example.

Link to tracking Issue:
There is no issue for that yet.

Testing:
There is no code changes.

Documentation:
There have a release (0.25.0) had updated the new relic exporter's configuration format. But the new document's config sample is not correct(#3091). The existing documents shows.

exporters:
  newrelic:
    apikey: super-secret-api-key
    timeout: 30s

  # host_override is set to send data to New Relic's EU data centers.
  traces:
    host_override: trace-api.eu.newrelic.com
    timeout: 20s
  metrics:
    host_override: metric-api.eu.newrelic.com
  logs:
    host_override: log-api.eu.newrelic.com

But the correct format should be

exporters:
  newrelic:
    apikey: super-secret-api-key
    timeout: 30s

    # host_override is set to send data to New Relic's EU data centers.
    traces:
      host_override: trace-api.eu.newrelic.com
      timeout: 20s
    metrics:
      host_override: metric-api.eu.newrelic.com
    logs:
      host_override: log-api.eu.newrelic.com

@Shihao-Zhong Shihao-Zhong requested a review from a team April 21, 2021 16:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2021

CLA Signed

The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #3194 (bbc2ac5) into main (be47f6f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3194   +/-   ##
=======================================
  Coverage   91.92%   91.92%           
=======================================
  Files         493      493           
  Lines       23946    23946           
=======================================
  Hits        22012    22012           
  Misses       1428     1428           
  Partials      506      506           
Flag Coverage Δ
integration 63.35% <ø> (-0.06%) ⬇️
unit 90.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be47f6f...bbc2ac5. Read the comment docs.

@bogdandrutu
Copy link
Member

Please sign the CLA

@a-feld
Copy link
Member

a-feld commented Apr 22, 2021

Thanks for your contribution @Shihao-Zhong ! ❤️

@bogdandrutu bogdandrutu merged commit a75b54e into open-telemetry:main Apr 22, 2021
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
…ter documents (open-telemetry#3194)

* docs(exporter/newrelicexporter/README.md): Update the new relic exporter's config example

* docs(exporter/newrelicexporter/README.md): Update the indent by @a-feld's suggestion

* docs(exporter/newrelicexporter/README.md): fix indent

n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants