Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configs+readmes to reflect de-squash of tls #5428

Merged
merged 1 commit into from
Sep 26, 2021

Conversation

justaverylee
Copy link
Contributor

Changed some example/test configs which did not compile since the tls struct (under grpc config) was changed from squashed to not squashed in the main parent repo (not -contrib). All changes are indenting insecure or other tls properties under the tls label.

Link to tracking Issue:
In parent repo the issue causing these errors are discussed in this issue: open-telemetry/opentelemetry-collector#4028
And specifically this merge: open-telemetry/opentelemetry-collector#4063

There is an issue in this (-contrib) repo discussing this: #5385

Testing:
No changes. Some example configs and readme demo configs now pass the config validation at startup.

Documentation:
Updated appropriate readmes to match change described above. Let me know if I missed some!

@justaverylee justaverylee requested a review from a team September 24, 2021 04:22
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 24, 2021

CLA Signed

The committers are authorized under a signed CLA.

@hyunuk
Copy link
Contributor

hyunuk commented Sep 24, 2021

Thanks for the PR! I was looking for the similar issue and I found these files also needs to be updated.

exporter/datadogexporter/example/example_k8s_manifest.yaml
exporter/elasticsearchexporter/README.md
exporter/prometheusremotewriteexporter/README.md
extension/awsxrayproxy/README.md
extension/awsxrayproxy/testdata/config.yaml
extension/oauth2clientauthextension/README.md
receiver/awsxrayreceiver/README.md
receiver/awsxrayreceiver/testdata/config.yaml

Just wanted to let you know that I'm currently working on this issue since some of config.go files in each components haven't been applied this changes you mentioned, extension/awsxrayproxy and receiver/awsxrayreceiver will fail on tests if you make change in these files above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants