Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove squash on configtls.TLSClientSetting in contrib #5433

Closed
6 tasks done
Aneurysm9 opened this issue Sep 24, 2021 · 1 comment
Closed
6 tasks done

Remove squash on configtls.TLSClientSetting in contrib #5433

Aneurysm9 opened this issue Sep 24, 2021 · 1 comment
Assignees
@hyunuk

Comments

@Aneurysm9
Copy link
Member

Aneurysm9 commented Sep 24, 2021 •
edited
Loading

Describe the issue

Based on this PR (open-telemetry/opentelemetry-collector#4063) in collector repo, configtls.TLSClientSetting should be defined as mapstructure: "tls,omitempty".

Below links are files where changes are needed:
@hyunuk
Copy link
Contributor

hyunuk commented Sep 24, 2021

@Aneurysm9 , please assign me this issue!

This was referenced Sep 24, 2021
Merged
Merged
Merged
Merged
Merged
tigrannajaryan pushed a commit that referenced this issue Oct 4, 2021
fix: remove squash on configtls.TLSClientSetting for observiqexporter (…
79d95af 
…#5540)

This PR removes squash on`configtls.TLSClientSetting` and update corresponding yaml file for observiqexporter.
See history [here](#5454)

**Link to tracking Issue:**
#5433
@hyunuk hyunuk mentioned this issue Oct 4, 2021
Closed
6 tasks
tigrannajaryan pushed a commit that referenced this issue Oct 6, 2021
fix: remove squash on configtls.TLSClientSetting for splunkhecexporter (
7fecacb 
#5541)

This PR removes squash on`configtls.TLSClientSetting` and update corresponding yaml file for splunkhecexporter.
See history [here](#5454)

**Link to tracking Issue:**
#5433
povilasv referenced this issue in coralogix/opentelemetry-collector-contrib Dec 19, 2022
@atingchen
Implement unmarshal metrics with jsoniter (#5433)
ada07a5 
* Implement unmarshal metrics with jsoniter

* Implement unmarshal metrics with jsoniter AND add test file

* add unit testing

* add unit testing

* git rebase main

* do a matrix testing for all 8 cases for a combination of these 3 bool options.

* some func is deprecated

* go imports

* go imports

* Update change log

* generate the 8 cases per tested func to avoid repeating test case definition

* 1. Remove instrumentationLibraryMetrics and instrumentation_library_metrics.

2. Some functions move to pdata/internal/json

3.Ignore unknown fields and have a debug log for them

* add test unit

* update CHANGELOG

* remove the new API AND reuse the other API NewJSONUnmarshaler

* update CHANGELOG

* update CHANGELOG

* go mod tidy

* remove unnecessary return true on the default branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyunuk hyunuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Aneurysm9 @hyunuk