Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove squash on configtls.TLSClientSetting for AWS components #5454

Merged
merged 11 commits into from
Oct 1, 2021
Merged

fix: remove squash on configtls.TLSClientSetting for AWS components #5454

merged 11 commits into from
Oct 1, 2021

Conversation

hyunuk
Copy link
Contributor

@hyunuk hyunuk commented Sep 27, 2021 •
edited
Loading

Description:
This PR removes squash onconfigtls.TLSClientSetting and update corresponding yaml files to ensure that the unit test passed.

Link to tracking Issue:
#5433

@hyunuk hyunuk requested a review from a team September 27, 2021 18:56
bogdandrutu
bogdandrutu reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to split into a PR that fixes the broken readmes and other that change the other components to not squash

@hyunuk
Copy link
Contributor Author

hyunuk commented Sep 27, 2021

@bogdandrutu I split them into the first two commits in this PR.
But if they are splitted into two PRs, each of them cannot pass build-and-test/unittest(pull_request) in Github actions, which is labeled as Required.

bogdandrutu
bogdandrutu reviewed Sep 28, 2021
View reviewed changes
examples/demo/otel-collector-config.yaml Outdated Show resolved Hide resolved
exporter/datadogexporter/example/example_k8s_manifest.yaml Outdated Show resolved Hide resolved
exporter/opencensusexporter/README.md Outdated Show resolved Hide resolved
exporter/opencensusexporter/README.md Outdated Show resolved Hide resolved
exporter/prometheusremotewriteexporter/README.md Outdated Show resolved Hide resolved
exporter/prometheusremotewriteexporter/README.md Outdated Show resolved Hide resolved
exporter/zipkinexporter/README.md Outdated Show resolved Hide resolved
exporter/zipkinexporter/README.md Outdated Show resolved Hide resolved
extension/oauth2clientauthextension/README.md Outdated Show resolved Hide resolved
@hyunuk hyunuk mentioned this pull request Sep 28, 2021
Merged
@hyunuk hyunuk requested a review from bogdandrutu September 28, 2021 04:20
bogdandrutu
bogdandrutu requested changes Sep 29, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #5466 (review)

@hyunuk hyunuk requested a review from bogdandrutu September 29, 2021 18:22
@alolita alolita added the ready to merge Code review completed; ready to merge by maintainers label Sep 29, 2021
@bogdandrutu
Copy link
Member

Consider to split per component: splunk/observiq/elastic/aws, since this has approver from aws owners this may contain the aws changes, and create other 3 PRs. We need component owners to ack these changes.

@bogdandrutu bogdandrutu removed the ready to merge Code review completed; ready to merge by maintainers label Sep 30, 2021
@hyunuk hyunuk changed the title fix: remove squash on configtls.TLSClientSetting fix: remove squash on configtls.TLSClientSetting for AWS components Oct 1, 2021
This was referenced Oct 1, 2021
Merged
Merged
Merged
@bogdandrutu bogdandrutu merged commit 5118335 into open-telemetry:main Oct 1, 2021
tigrannajaryan pushed a commit that referenced this pull request Oct 4, 2021
fix: remove squash on configtls.TLSClientSetting for observiqexporter (…
79d95af 
…#5540)

This PR removes squash on`configtls.TLSClientSetting` and update corresponding yaml file for observiqexporter.
See history [here](#5454)

**Link to tracking Issue:**
#5433
@hyunuk hyunuk mentioned this pull request Oct 4, 2021
Closed
6 tasks
tigrannajaryan pushed a commit that referenced this pull request Oct 6, 2021
fix: remove squash on configtls.TLSClientSetting for splunkhecexporter (
7fecacb 
#5541)

This PR removes squash on`configtls.TLSClientSetting` and update corresponding yaml file for splunkhecexporter.
See history [here](#5454)

**Link to tracking Issue:**
#5433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@anuraaga anuraaga anuraaga approved these changes

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

@mx-psi mx-psi Awaiting requested review from mx-psi

Assignees

@mx-psi mx-psi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hyunuk @bogdandrutu @anuraaga @Aneurysm9 @alolita @mx-psi