Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove squash on configtls.TLSClientSetting for elastic components #5539

Merged

Conversation

hyunuk
Copy link
Contributor

@hyunuk hyunuk commented Oct 1, 2021

Description:
This PR removes squash onconfigtls.TLSClientSetting and update corresponding README files for elasticexporter and elasticsearchexporter.
See history here

Link to tracking Issue:
#5433

@hyunuk hyunuk requested review from a team and tigrannajaryan October 1, 2021 01:25
@bogdandrutu
Copy link
Member

Please rebase

@tigrannajaryan
Copy link
Member

@axw @simitt @jalvz please review.

@tigrannajaryan
Copy link
Member

@hyunuk please rebase and resolve the conflicts.

@bogdandrutu bogdandrutu merged commit 7b60adb into open-telemetry:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants