Rename "label" to "attribute" in expression matcher DSL #5862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The expression matcher used the old terminology in functions HasLabel/Label. The current Otel term for metrics dimension is "attribute". I renamed the functions to HasAttribute/Attribute and kept HasLabel/Label as aliases for now to avoid breaking existing configurations. HasLabel/Label are declared deprecated, we can remove them in a few months / before declaring the config stable.
bogdandrutu
requested changes
Oct 21, 2021
There was a problem hiding this comment.
I think we should finalize the configuration that we want for "filtering" before making more changes. @punya promised long time ago to own this.
|
Ack. I will aim to have something we can discuss by the next SIG meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expression matcher used the old terminology in functions
HasLabel/Label. The current Otel term for metrics dimension is
"attribute".
I renamed the functions to HasAttribute/Attribute and kept HasLabel/Label
as aliases for now to avoid breaking existing configurations. HasLabel/Label
are declared deprecated, we can remove them in a few months / before
declaring the config stable.