Improve performance of metric expression matcher #5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Oct 21, 2021
|
Based on @bogdandrutu 's comment on #5862 I will redo this to only include perf improvements. |
Refactored env struct to avoid creating closure functions for every expression evaluation operation. This reduced the allocations and increased the speed. Improvements: $ benchstat old.txt new.txt name old time/op new time/op delta ExprFilter-8 537µs ± 2% 476µs ± 1% -11.33% (p=0.000 n=9+10) name old alloc/op new alloc/op delta ExprFilter-8 151kB ± 0% 102kB ± 0% -32.43% (p=0.000 n=8+8) name old allocs/op new allocs/op delta ExprFilter-8 8.44k ± 0% 6.39k ± 0% -24.24% (p=0.000 n=10+10)
tigrannajaryan
force-pushed
the
expr-perf-improve
branch
from
77854a0 to
c46a52a
Compare
|
Updated to only be about perf improvement (instead of being stacked on top of another PR). |
codeboten
approved these changes
Oct 21, 2021
bogdandrutu
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored env struct to avoid creating closure functions for every
expression evaluation operation. This reduced the allocations and
increased the speed.
Improvements: