Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prometheus remote write exporter to collector default package #1150

Closed
markcartertm opened this issue Jun 18, 2020 · 15 comments
Closed

Add Prometheus remote write exporter to collector default package #1150

markcartertm opened this issue Jun 18, 2020 · 15 comments
Assignees
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@markcartertm
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
We need to add a Prometheus exporter that can push prometheus data from the collector to a Prometheus remote write API endpoint.
A goal of the OpenTelemetry collector is to provide built in support for ingestion and export of Prometheus metrics. currently, OTEL collector includes a Prometheus exporter that exposes /metrics allowing a Prometheus server to scrape the collector. we currently do not have an exporter that allows the collector to push collected metrics to a remote write backend such as CorTex. if we were to add remote write support we can eliminate the need to run a Prometheus server in a Kubernetes cluster just to scrape the prometheus node exporters and send to a remote write API.
Describe the solution you'd like
A clear and concise description of what you want to happen.
We need to add a new Prometheus exporter that can send data to a prometheus remote write backend such as Cortex,Thanos, Spanner, SignalFX, InffluxDB, Elasticsearch etc. such an exporter will be included in the default collector package. by adding Prometheus remote write exporter we will significantly increase the number of metric backends that OTEL collector can send metrics to by default.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
There really aren't any.
Additional context
Add any other context or screenshots about the feature request here.
List of remote write destinations supported by Prometheus that will be enabled by adding remote write support in OTEL:
https://prometheus.io/docs/operating/integrations/

@markcartertm
Copy link
Author

@alolita can we get an intern to drive a POC for this together with a mentor?

@alolita
Copy link
Member

alolita commented Jun 18, 2020

@markcartertm we've already assigned an intern to work on this. Thanks for filing an issue!

Following up on requesting a OTEL Collector mentor.

@jmacd
Copy link
Contributor

jmacd commented Jun 22, 2020

Are you interested in support for receiving Prometheus push data, too?

@alolita
Copy link
Member

alolita commented Jun 23, 2020

Hi! @jmacd yes would definitely like to understand the requirements to build this out. Would you have some cycles to review our design and code?

@dabangarang
Copy link
Contributor

Hi just to understand @alolita this is not the project that Yang and I are in charge of? I was under the impression that we will not make use of Prometheus remote write, but instead, create an exporter that ports directly to the backends of interest directly.

@jmacd
Copy link
Contributor

jmacd commented Jun 23, 2020

I am happy to help, @alolita. I have read through the current otel-collector implementation of the Prometheus receiver and exporter, and I've also been working on specifying how Prometheus data transformation should work by default (open-telemetry/oteps#118).

@huyan0
Copy link
Member

huyan0 commented Jul 9, 2020

I am working on this issue.

@alolita
Copy link
Member

alolita commented Jul 9, 2020

HI @jmacd thanks for the offer :-) Two of our intern engineers @huyan0 and @danielbang907 (in the process of gaining membership) are working with me on this Prometheus read/write exporter. Please assign us - @alolita @huyan0 to this issue. Many thanks!

@bogdandrutu bogdandrutu added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label Jul 30, 2020
@bogdandrutu bogdandrutu added this to the GA 1.0 milestone Jul 30, 2020
@morigs
Copy link
Contributor

morigs commented Aug 6, 2020

#1464 document seems detailed enough and ready for use. What are the plans for implementation? I need this exporter too and ready to contribute

@huyan0
Copy link
Member

huyan0 commented Aug 6, 2020

@morigs code PRs should be coming in this week. We will keep you updated : )

@alolita
Copy link
Member

alolita commented Aug 7, 2020

Hi @bogdandrutu can you assign this issue to me @alolita, @huyan0 and @danielbang907 - we are working on this implementation in #1464

@tigrannajaryan
Copy link
Member

@alolita where are we with this? I see there is a related PR. Is there more work expected on this?

@alolita
Copy link
Member

alolita commented Oct 2, 2020

Hi @tigrannajaryan @bogdandrutu The Prometheus remote write exporter has been completed and merged. We will open separate PRs for SIGv4 support and compliance with latest OTLP changes. The core is complete and merged. This issue can be closed.

@tigrannajaryan
Copy link
Member

Thanks @alolita

@PatrikSteuer
Copy link

Is there ongoing work to provide a remote write receiver as well? This would allow prometheus servers to push metrics to a remote collector.

@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
…s/trace/zipkin (open-telemetry#1150)

* Bump github.com/openzipkin/zipkin-go in /exporters/trace/zipkin

Bumps [github.com/openzipkin/zipkin-go](https://github.com/openzipkin/zipkin-go) from 0.2.3 to 0.2.4.
- [Release notes](https://github.com/openzipkin/zipkin-go/releases)
- [Commits](openzipkin/zipkin-go@v0.2.3...v0.2.4)

Signed-off-by: dependabot[bot] <support@github.com>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

10 participants