-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Prometheus Remote Write Exporter supporting Cortex - conversion and export for Histogram OTLP metrics #1643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1643 +/- ##
==========================================
+ Coverage 92.37% 92.40% +0.03%
==========================================
Files 265 265
Lines 19909 19952 +43
==========================================
+ Hits 18390 18437 +47
+ Misses 1090 1088 -2
+ Partials 429 427 -2
Continue to review full report at Codecov.
|
Please split this into 2 PRs the first being the Histogram. We will not support Summary for few weeks in the new otlp and that will get delayed. |
Please increase the coverage :) |
Will do. Also rebasing : ) |
7b952a7
to
73f05c5
Compare
Got 100% diff coverage now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of unnecessary changes can you please fix them?
Addressed some comments. Really appreciate the review. Will start working on #1681 |
@huyan0 @bogdandrutu @EdZou @ercl - I see the prometheus histograms represented as OTEL histograms, during which the values are becoming delta ( see design here - https://github.com/open-telemetry/opentelemetry-collector/blob/main/receiver/prometheusreceiver/DESIGN.md#histogram ). I see the same issue with summary (for _sum & _count) and also counters. Is there a way to configure the receiver to NOT do the delta/diff from first scrape ? If not, how to get the original values as scraped for these metrics to be able to ingest to prometheus thru the prometheus exporter? |
This PR is part of a series of PRs implementing a Prometheus remote write exporter supporting Cortex.
See related PR #1577
Description: This PR adds export support for histogram and summary metrics for Prometheus remote write integrated backends, such as Cortex. The exporter drops non-cumulative monotonic, histogram, and summary OTLP metrics.
Please note this metrics exporter does not support Prometheus default labels such as
job
orinstance
labels. An issue addressing Prometheus default labels will be filed later. Another related feature is to derive labels from a Resource. This functionality already exists in the Go SDK and will be implemented in another PR. This feature could allow users to specify which attributes they want to add as labels.Link to tracking Issue: #1150
Related issues are:
Metrics aggregation proposal: #1422
Prometheus exporter not functional: #1255
Related spec discussion: #731
Documentation:
readme.md with sample configuration, file structure, and assumptions
Design documentation: PR Add Cortex and Prometheus Remote Write exporter design #1464
cc: @huyan0 @alolita @jmacd @bogdandrutu