Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass "Settings" to all obsreport packages #3922

Closed
bogdandrutu opened this issue Aug 30, 2021 · 2 comments
Closed

Pass "Settings" to all obsreport packages #3922

bogdandrutu opened this issue Aug 30, 2021 · 2 comments
Assignees
@anuraaga @Aneurysm9
Labels
area:internal
Milestone
core-release-v37

Comments

@bogdandrutu
Copy link
Member

Similar to the #3789 we need to update all obsreport packages. We use now only the TracerProvider from Settings, but soon MeterProvider will be added when changed to otel metrics, so this is important.
@bogdandrutu bogdandrutu added this to the Milestone-core-rc-release milestone Aug 30, 2021
@bogdandrutu bogdandrutu mentioned this issue Aug 30, 2021
Closed
@alolita
Copy link
Member

alolita commented Sep 2, 2021 •
edited
Loading

@Aneurysm9 @anuraaga can you please take a look, provide your comments on implementation - ty!

@alolita alolita added area:internal release:required-for-ga Must be resolved before GA release labels Sep 2, 2021
@bogdandrutu bogdandrutu mentioned this issue Sep 3, 2021
Merged
@Aneurysm9 Aneurysm9 mentioned this issue Sep 7, 2021
Closed
@Aneurysm9 Aneurysm9 linked a pull request Sep 9, 2021 that will close this issue
wire up obsreport settings #3982
Closed
@alolita alolita removed the release:required-for-ga Must be resolved before GA release label Sep 13, 2021
@alolita
Copy link
Member

alolita commented Sep 14, 2021

@Aneurysm9 any other PRs for this issue IP?

This was referenced Sep 29, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anuraaga anuraaga

@Aneurysm9 Aneurysm9

Labels
area:internal
Projects
None yet
Milestone
core-release-v37
Development

Successfully merging a pull request may close this issue.

wire up obsreport settings Aneurysm9/opentelemetry-collector
4 participants
@anuraaga @Aneurysm9 @bogdandrutu @alolita