Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Tracer/Meter Provider to http/grpc configs to record metrics #3931

Closed
bogdandrutu opened this issue Aug 30, 2021 · 2 comments · Fixed by #3967
Closed

Pass Tracer/Meter Provider to http/grpc configs to record metrics #3931

bogdandrutu opened this issue Aug 30, 2021 · 2 comments · Fixed by #3967
Assignees
@codeboten
Labels
area:config release:required-for-ga Must be resolved before GA release
Milestone
core-rc-release-v36

Comments

@bogdandrutu
Copy link
Member

Similar to #3922 need to pass these providers to configgrpc / confighttp funcs that need to install the otel plugins.
@bogdandrutu bogdandrutu added this to the Milestone-core-rc-release milestone Aug 30, 2021
@alolita
Copy link
Member

alolita commented Sep 2, 2021

@codeboten can you please take a look and file a PR?

@alolita alolita added area:config release:required-for-ga Must be resolved before GA release labels Sep 2, 2021
This was referenced Sep 2, 2021
Merged
Merged
@bogdandrutu
Copy link
Member Author

@codeboten don't want to block the #3984, we should think if a better name is just "TelemetrySettings".

@codeboten codeboten mentioned this issue Sep 8, 2021
Merged
@codeboten codeboten mentioned this issue Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
area:config release:required-for-ga Must be resolved before GA release
Projects
None yet
Milestone
core-rc-release-v36
Development

Successfully merging a pull request may close this issue.

use ReceiverCreateSettings to configure TracerProvider codeboten/opentelemetry-collector
3 participants
@codeboten @bogdandrutu @alolita