use ReceiverCreateSettings to configure TracerProvider #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
reviewed
Sep 3, 2021
codeboten
force-pushed
the
codeboten/add-meter-provider
branch
from
252737f to
ec7c062
Compare
bogdandrutu
reviewed
Sep 9, 2021
bogdandrutu
approved these changes
Sep 10, 2021
| @@ -270,7 +270,7 @@ func (gss *GRPCServerSettings) ToListener() (net.Listener, error) { | |||
| } | |||
|
|
|||
| // ToServerOption maps configgrpc.GRPCServerSettings to a slice of server options for gRPC. | |||
| func (gss *GRPCServerSettings) ToServerOption(ext map[config.ComponentID]component.Extension) ([]grpc.ServerOption, error) { | |||
| func (gss *GRPCServerSettings) ToServerOption(ext map[config.ComponentID]component.Extension, settings component.TelemetrySettings) ([]grpc.ServerOption, error) { | |||
There was a problem hiding this comment.
Just file an issue for me to investigate if better to pass the Host not the extensions only.
bogdandrutu
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Pass in
ReceiverCreateSettingsto confighttp/configgrpc to support configuring TracerProvider and in the near future MeterProvider.Link to tracking Issue: Fix #3931