Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obsreport: wire up ProcessorCreateSettings for processors using obsreport #4148

Merged

Conversation

Aneurysm9
Copy link
Member

Signed-off-by: Anthony J Mirabella a9@aneurysm9.com

Link to tracking Issue: #3922

…port

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 requested review from a team and bogdandrutu September 29, 2021 22:45
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4148 (e11d01d) into main (896335f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4148   +/-   ##
=======================================
  Coverage   87.66%   87.67%           
=======================================
  Files         174      174           
  Lines       10224    10230    +6     
=======================================
+ Hits         8963     8969    +6     
  Misses       1011     1011           
  Partials      250      250           
Impacted Files Coverage Δ
obsreport/obsreport_processor.go 94.23% <ø> (ø)
config/configtest/configtest.go 96.66% <100.00%> (ø)
obsreport/obsreporttest/obsreporttest.go 62.93% <100.00%> (+1.06%) ⬆️
processor/memorylimiterprocessor/factory.go 100.00% <100.00%> (ø)
processor/memorylimiterprocessor/memorylimiter.go 88.58% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69935d8...e11d01d. Read the comment docs.

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Anthony J Mirabella <a9@aneurysm9.com>
@bogdandrutu bogdandrutu merged commit ee7fa0e into open-telemetry:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants