Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release script did not create Github release #6849

Closed
mx-psi opened this issue Dec 23, 2022 · 7 comments · Fixed by #6976 or #7596
Closed

Release script did not create Github release #6849

mx-psi opened this issue Dec 23, 2022 · 7 comments · Fixed by #6976 or #7596
Labels
bug Something isn't working release

Comments

@mx-psi
Copy link
Member

mx-psi commented Dec 23, 2022 •
edited
Loading

On the v0.68.0 release cycle, the release script did not create a v0.68.0 Github release, creating only a cmd/builder/v0.68.0 release instead.

This caused trouble on the opentelemetry-collector-releases repository, where we had to fix the URL on open-telemetry/opentelemetry-collector-releases#256.

I am creating the Github release manually myself for this release, but it would be great to go back to have releases be done automatically and be consistent with each other.

This also happened on v0.70.0 and v0.76.0
@mx-psi mx-psi added bug Something isn't working release labels Dec 23, 2022
@mx-psi mx-psi mentioned this issue Dec 23, 2022
Merged
@djaglowski
Copy link
Member

@mx-psi, I may need to do this manually today - can you help me understand what specifically was done manually?

@mx-psi
Copy link
Member Author

mx-psi commented Jan 10, 2023

Looks like it worked this time? What I did was manually creating a new release pointing to the v0.68.0 tag with the same structure as previous releases, and adding a link to the cmd/builder/v0.68.0 release to it, so that people could find the release link

@djaglowski
Copy link
Member

Thanks @mx-psi. If I recall correctly, the generated release was named cmd/builder/v0.69.0, but it seemed to contain all the artifacts expected in prior releases, so I just renamed it.

codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jan 19, 2023
[chore] update release build job to trigger on v* tag push
61eada2 
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.

Fix open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue Jan 19, 2023
Merged
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jan 19, 2023
[chore] update release build job to trigger on v* tag push
ab9a5f7 
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.

Fix open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jan 19, 2023
[chore] update release build job to trigger on v* tag push
efac004 
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.

Fix open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
bogdandrutu pushed a commit that referenced this issue Jan 20, 2023
[chore] update release build job to trigger on v* tag push (#6976)
b6a3dc5 
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.

Fix #6849

Signed-off-by: Alex Boten <aboten@lightstep.com>

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Jan 23, 2023
[chore] update release build job to trigger on v* tag push (open-tele…
1301055 
…metry#6976)

In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.

Fix open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>

Signed-off-by: Alex Boten <aboten@lightstep.com>
@dmitryax dmitryax reopened this Jan 23, 2023
@dmitryax
Copy link
Member

Looks like it's still the case. v0.70.0 release was not created automatically

@mx-psi
Copy link
Member Author

mx-psi commented Mar 10, 2023

Did you run into this on the last release @Aneurysm9?

@Aneurysm9
Copy link
Member

No. You can see here that the release was created by github-actions.

@codeboten codeboten reopened this Apr 28, 2023
@mx-psi mx-psi changed the title v0.68.0 release job did not create 'v0.68.0' Github release Release script did not create Github release May 2, 2023
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue May 2, 2023
[chore] add step to create a release for v* tag
4cf0e84 
Fixes open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue May 2, 2023
[chore] add step to create a release for v* tag
7290aaa 
Fixes open-telemetry#6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue May 2, 2023
Merged
@codeboten
Copy link
Contributor

Added a separate step in the action to create the release for the v* tag in #7596

codeboten pushed a commit that referenced this issue May 3, 2023
[chore] add step to create a release for v* tag (#7596)
2c132fa 
Fixes #6849

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release
Projects
None yet
Milestone
No milestone
5 participants
@codeboten @Aneurysm9 @djaglowski @mx-psi @dmitryax