[chore] update release build job to trigger on v* tag push #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
commented
Jan 19, 2023
There was a problem hiding this comment.
Pinging @mx-psi and @djaglowski who both ran into issues with the last releases.
codeboten
force-pushed
the
codeboten/fix-6849
branch
from
61eada2 to
ab9a5f7
Compare
Codecov ReportBase: 90.64% // Head: 90.64% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6976 +/- ##
=======================================
Coverage 90.64% 90.64%
=======================================
Files 241 241
Lines 14523 14523
=======================================
Hits 13164 13164
Misses 1091 1091
Partials 268 268 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point. Fix open-telemetry#6849 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/fix-6849
branch
from
ab9a5f7 to
efac004
Compare
MovieStoreGuy
approved these changes
Jan 19, 2023
mx-psi
approved these changes
Jan 20, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-collector
that referenced
this pull request
Jan 23, 2023
…metry#6976) In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point. Fix open-telemetry#6849 Signed-off-by: Alex Boten <aboten@lightstep.com> Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last 3 releases, this job has created a release for the cmd/builder/v* tag, which caused an issue in the release process and introduced additional manual steps. An alternative to this would be to create two releases, one for the builder and one for the collector, but that seems overkill at this point.
Fix #6849
Signed-off-by: Alex Boten aboten@lightstep.com