[batchprocessor] fix broken processor_batch_metadata_cardinality metric #10232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#10231 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10232 +/- ##
==========================================
+ Coverage 92.54% 92.55% +0.01%
==========================================
Files 387 387
Lines 18198 18198
==========================================
+ Hits 16841 16843 +2
+ Misses 1016 1015 -1
+ Partials 341 340 -1 ☔ View full report in Codecov by Sentry. |
jpkrohling
approved these changes
May 27, 2024
codeboten
added a commit
that referenced
this pull request
May 28, 2024
Follows #10232, use mdatagen for async counter --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…ic (open-telemetry#10232) Fixes open-telemetry#10231 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
Follows open-telemetry#10232, use mdatagen for async counter --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10231