[batchprocessor] use mdatagen for async metric #10233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10233 +/- ##
==========================================
- Coverage 92.47% 92.47% -0.01%
==========================================
Files 387 387
Lines 18252 18246 -6
==========================================
- Hits 16879 16873 -6
Misses 1027 1027
Partials 346 346 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/mdatagen-updowncounter-batch
branch
from
a46f4e2
to
04c71b0
Compare
This removes the custom code in the processor in favour of the generated mdatagen test code. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
This was referenced May 28, 2024
TylerHelmuth
approved these changes
May 28, 2024
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
Follows open-telemetry#10232, use mdatagen for async counter --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #10232, use mdatagen for async counter