[batchprocessor] ensure attributes are set on metadata metric #10245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follows #10233 |
Fixing this bug required a change in mdatagen to ensure attributes could be passed in to the telemetry builder. Fixes open-telemetry#9674 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/fix-9674
branch
from
6065b2d
to
6db9526
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10245 +/- ##
==========================================
- Coverage 92.48% 92.44% -0.04%
==========================================
Files 387 387
Lines 18244 18256 +12
==========================================
+ Hits 16873 16877 +4
- Misses 1025 1031 +6
- Partials 346 348 +2 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
May 29, 2024
steves-canva
pushed a commit
to Canva/opentelemetry-collector
that referenced
this pull request
Jun 14, 2024
…elemetry#10245) Fixing this bug required a change in mdatagen to ensure attributes could be passed in to the telemetry builder. Fixes open-telemetry#9674 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this bug required a change in mdatagen to ensure attributes could be passed in to the telemetry builder.
Fixes #9674