Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[chore] use mdatagen to generate service metrics (#10160)" #10271

Merged
merged 1 commit into from
May 30, 2024
Merged

Revert "[chore] use mdatagen to generate service metrics (#10160)" #10271

merged 1 commit into from
May 30, 2024

Conversation

codeboten
Copy link
Contributor

This reverts commit 10bcef3.

@codeboten codeboten requested a review from a team as a code owner May 30, 2024 18:15
@codeboten codeboten requested a review from dmitryax May 30, 2024 18:15
@codeboten codeboten mentioned this pull request May 30, 2024
Open
@codecov Codecov
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.49%. Comparing base (10bcef3) to head (9fdc6f6).
Report is 1 commits behind head on main.

Files Patch % Lines
service/service.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10271      +/-   ##
==========================================
- Coverage   92.50%   92.49%   -0.02%     
==========================================
  Files         388      387       -1     
  Lines       18288    18259      -29     
==========================================
- Hits        16917    16888      -29     
  Misses       1025     1025              
  Partials      346      346

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codeboten codeboten merged commit 1749a8f into open-telemetry:main May 30, 2024
48 checks passed
@codeboten codeboten deleted the codeboten/revert-10bcef33e6d26104036ed2874cb179c4437abc98 branch May 30, 2024 18:45
@github-actions github-actions bot added this to the next release milestone May 30, 2024
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request May 30, 2024
@codeboten
Revert "Revert "[chore] use mdatagen to generate service metrics (ope…
c8092f2 
…n-telemetry#10160)" (open-telemetry#10271)"

This reverts commit 1749a8f.
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request May 30, 2024
@codeboten
[service] use mdatagen for service metrics
bbd3472 
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request May 30, 2024
@codeboten
[service] use mdatagen for service metrics
f223fbc 
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten mentioned this pull request May 30, 2024
Merged
codeboten added a commit to codeboten/opentelemetry-collector that referenced this pull request Jun 7, 2024
@codeboten
[service] use mdatagen for service metrics
58a946a 
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten added a commit that referenced this pull request Jun 10, 2024
@codeboten
[service] use mdatagen for service metrics (#10273)
a2289fd 
This reverts the reverts
#10271 and
adds a mechanism to skip adding a create settings method for the service
package component test. Will need to figure out if
servicetelemetry.TelemetrySettings should be renamed to fit w/ the other
CreateSettings structs before removing this check.

Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
steves-canva pushed a commit to Canva/opentelemetry-collector that referenced this pull request Jun 14, 2024
@codeboten @steves-canva
Revert "[chore] use mdatagen to generate service metrics (open-teleme…
33acd13 
…try#10160)" (open-telemetry#10271)

This reverts commit 10bcef3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.102.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codeboten @TylerHelmuth