-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service] use mdatagen for service metrics #10273
[service] use mdatagen for service metrics #10273
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10273 +/- ##
==========================================
- Coverage 92.56% 92.52% -0.04%
==========================================
Files 387 388 +1
Lines 18254 18297 +43
==========================================
+ Hits 16896 16929 +33
- Misses 1014 1022 +8
- Partials 344 346 +2 ☔ View full report in Codecov by Sentry. |
This reverts the reverts open-telemetry#10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check. Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
8091e6c
to
58a946a
Compare
…2874cb179c4437abc98
ignore: | ||
top: | ||
# See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information. | ||
- "go.opencensus.io/stats/view.(*worker).start" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is because of ./internal/proctelemetry/config.go only, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct
This reverts the reverts #10271 and adds a mechanism to skip adding a create settings method for the service package component test. Will need to figure out if servicetelemetry.TelemetrySettings should be renamed to fit w/ the other CreateSettings structs before removing this check.