[confighttp] Add read_timeout and read_header_timeout options to confighttp
#10274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10274 +/- ##
=======================================
Coverage 92.38% 92.38%
=======================================
Files 403 403
Lines 18729 18732 +3
=======================================
+ Hits 17303 17306 +3
Misses 1066 1066
Partials 360 360 ☔ View full report in Codecov by Sentry. |
|
This is on hold, after merging #10276 |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@atoulme , is this still up to date? |
…confighttp, to use as HTTP server config options.
atoulme
force-pushed
the
confighttp_read_timeout
branch
from
589f59b
to
ef9441e
Compare
|
@jpkrohling rebased and ready to go. |
| Handler: mux, | ||
| Addr: address, | ||
| Handler: mux, | ||
| ReadHeaderTimeout: defaultReadHeaderTimeout, |
There was a problem hiding this comment.
Just to double-check. this is unrelated to the change above, right?
There was a problem hiding this comment.
it's because I also removed the gosec exception. The linter picked up the fact we didn't set this on the prometheus server as well.
|
There are a few test failures related to this change. Can you address them? |
I am not sure how - this new config field clashes with an existing config field from contrib, and performs the same function as that field. My thinking is that we'd merge this, and update contrib and change it to use the new field. WDYT? |
|
Right, the failures are in contrib-tests, I missed that. LGTM then. |
…
Description
Add
read_timeoutandread_header_timeoutoptions to confighttp, to use as HTTP server config options.Link to tracking issue
Fixes #5699
Testing
Documentation
Added to README.