[extension/zpages] zpagesextension using confighttp.ServerConfig #10276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
zpagesextension_confighttp
branch
2 times, most recently
from
e08ee4e
to
2d8b5d9
Compare
atoulme
force-pushed
the
zpagesextension_confighttp
branch
4 times, most recently
from
5c3608b
to
cb7c310
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10276 +/- ##
==========================================
+ Coverage 92.38% 92.39% +0.01%
==========================================
Files 387 387
Lines 18308 18312 +4
==========================================
+ Hits 16913 16920 +7
+ Misses 1049 1046 -3
Partials 346 346 ☔ View full report in Codecov by Sentry. |
atoulme
force-pushed
the
zpagesextension_confighttp
branch
5 times, most recently
from
19bf9d8
to
2f1e830
Compare
codeboten
reviewed
May 31, 2024
atoulme
force-pushed
the
zpagesextension_confighttp
branch
from
2f1e830
to
2293c1a
Compare
…ration of the zpagesextension
atoulme
force-pushed
the
zpagesextension_confighttp
branch
from
2293c1a
to
9a168a6
Compare
codeboten
approved these changes
Jun 7, 2024
|
Ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
use confighttp.ServerConfig as part of the configuration of the zpagesextension
Link to tracking issue
Fixes #9368