Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change host metrics receiver to use the new metrics internal structs #1682

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Aug 30, 2020

The most important changes are in the metadata files, others are just simple renaming.

Updates #1657

Depends on #1684 which adds the SetDataType and adds tests for it.

@codecov
Copy link

codecov bot commented Aug 30, 2020

Codecov Report

Merging #1682 into master will increase coverage by 0.00%.
The diff coverage is 98.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #1682    +/-   ##
========================================
  Coverage   92.28%   92.29%            
========================================
  Files         265      265            
  Lines       19818    19928   +110     
========================================
+ Hits        18290    18393   +103     
- Misses       1099     1105     +6     
- Partials      429      430     +1     
Impacted Files Coverage Δ
consumer/pdata/metric.go 73.72% <57.14%> (-1.75%) ⬇️
...ceiver/hostmetricsreceiver/hostmetrics_receiver.go 88.13% <75.00%> (ø)
...ceiver/internal/scraper/cpuscraper/cpu_metadata.go 100.00% <100.00%> (ø)
...eceiver/internal/scraper/cpuscraper/cpu_scraper.go 100.00% <100.00%> (ø)
...r/internal/scraper/cpuscraper/cpu_scraper_linux.go 100.00% <100.00%> (ø)
...iver/internal/scraper/diskscraper/disk_metadata.go 100.00% <100.00%> (ø)
...nternal/scraper/diskscraper/disk_scraper_others.go 100.00% <100.00%> (ø)
...l/scraper/diskscraper/disk_scraper_others_linux.go 100.00% <100.00%> (ø)
...l/scraper/filesystemscraper/filesystem_metadata.go 100.00% <100.00%> (ø)
...al/scraper/filesystemscraper/filesystem_scraper.go 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c9e7f...db86c70. Read the comment docs.

Copy link
Member

@james-bebbington james-bebbington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm - ignore all my previous comments.

The distinction between a Gauge and a non-monotomic Cumulative is:

  • A Cumulative can be used in any case where measurements are added: e.g. when data is written to disk, +some bytes, when data is deleted from disk, -some bytes
  • A Gauge is reserved for cases where the data source is not a sum or is not known, e.g. CPU Load (which is a moving average)

With that context, this all looks good.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu merged commit fc77725 into open-telemetry:master Aug 31, 2020
@bogdandrutu bogdandrutu deleted the hostrecv branch August 31, 2020 17:23
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
* initial version of the pulsar exporter (metrics). Tests yet to be added. (open-telemetry#1541)

authored-by: Shiva Param <sparam@paypal.com>
authored-by: Narasimha Rao <narasirao@paypal.com>
authored-by: narasimharaojm <madhunarasimharao@gmail.com>

* pulsarexporter: fix lint, remove failing tests (open-telemetry#1682)

This is an experimental component added by PayPal. Unit tests to be added later.
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants