Fix bug in copy data, the data were not deeply copied #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
- Coverage 92.28% 92.28% -0.01%
==========================================
Files 265 265
Lines 19818 19824 +6
==========================================
+ Hits 18290 18294 +4
- Misses 1099 1100 +1
- Partials 429 430 +1
Continue to review full report at Codecov.
|
dmitryax
approved these changes
Aug 31, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
* initial version of the pulsar exporter (metrics). Tests yet to be added. (open-telemetry#1541) authored-by: Shiva Param <sparam@paypal.com> authored-by: Narasimha Rao <narasirao@paypal.com> authored-by: narasimharaojm <madhunarasimharao@gmail.com> * pulsarexporter: fix lint, remove failing tests (open-telemetry#1682) This is an experimental component added by PayPal. Unit tests to be added later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1674