-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove legacy grpc receiver endpoint for GA release #3101
Conversation
Do we really want to do it before GA? There are so many tools, blog posts, and docs out there referencing this port that users will be frustrated when they follow those and things don't work as expected. |
In my opinion if we expect this change will break user's set up(in case if they are still using legacy port |
There are things we don't control, like external blog posts. I would rather release with silent support for the legacy port, and log a big warning if we see data getting in via the legacy port. |
@bogdandrutu what is the best path forward for this issue? Not sure if there have been any discussions happening on this. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR can be closed and a new one - #3256 created for removing all the occurrences of the legacy port |
@mxiamxia have you created a tracking PR for the remove of the port as we discussed after some more releases? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@bhautikpip @bogdandrutu , pls close this PR. |
Description: <Describe what has changed.
Removed OTLP receiver legacy endpoint which was still accepting data even after we switched to port
4317
for easy migration. Submitted a PR to remove legacy endpoint for GA release. Not sure when is the good time to merge this PR but thought this will be required before GA release.Link to tracking Issue: #2565
Testing: Ran
otlpreceiver
package unit tests by runninggo test -race go.opentelemetry.io/collector/receiver/otlpreceiver
commandDocumentation: < Describe the documentation added.>
Please delete paragraphs that you did not use before submitting.