Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove legacy grpc receiver endpoint for GA release #3256

Merged
merged 4 commits into from
May 26, 2021
Merged

remove legacy grpc receiver endpoint for GA release #3256

merged 4 commits into from
May 26, 2021

Conversation

mxiamxia
Copy link
Member

@mxiamxia mxiamxia commented May 21, 2021 •
edited
Loading

Description:
Extended from #3101, removed all the occurrences of the legacy port 55680 in the repo.

Removed OTLP receiver legacy endpoint which was still accepting data even after we switched to port 4317 for easy migration. Submitted a PR to remove legacy endpoint for GA release. Not sure when is the good time to merge this PR but thought this will be required before GA release.

Submitted CRs to remove 55680 from all of the OTEL SDKs and website/documentations. (track in the issue below)

Link to tracking Issue:
#2565

Testing:
Ran otlpreceiver package unit tests by running
go test -race go.opentelemetry.io/collector/receiver/otlpreceiver command

@mxiamxia mxiamxia requested a review from a team May 21, 2021 22:19
This was referenced May 21, 2021
Closed
Closed
bogdandrutu
bogdandrutu approved these changes May 25, 2021
View reviewed changes
receiver/otlpreceiver/otlp.go Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

I think it fails because of legacyGRPCEndpoint which was removed but still used in that code

@bogdandrutu bogdandrutu merged commit 1292bf4 into open-telemetry:main May 26, 2021
@alolita alolita mentioned this pull request Jun 3, 2021
Closed
dashpole pushed a commit to dashpole/opentelemetry-collector that referenced this pull request Jun 14, 2021
@mxiamxia @bogdandrutu @dashpole
remove legacy grpc receiver endpoint for GA release (open-telemetry#3256
ae4797c 
)

* remove legacy grpc receiver endpoint for GA release

* Update factory.go

Co-authored-by: Bogdan Drutu <lazy@splunk.com>
Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxiamxia @bogdandrutu @carlosalberto