Skip to content

Commit

Permalink
[PROMETHEUS_EXPORTER] Fix default for emitting otel_scope attributes (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
yashykt authored Nov 26, 2024
1 parent 955a807 commit 8d45dec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion exporters/prometheus/src/exporter_options.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ inline bool GetPrometheusWithoutOtelScope()
auto exists =
opentelemetry::sdk::common::GetBoolEnvironmentVariable(kPrometheusWithoutOtelScope, setting);

return exists ? setting : true;
return exists ? setting : false;
}

inline bool GetPrometheusPopulateTargetInfo()
Expand Down

1 comment on commit 8d45dec

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 8d45dec Previous: 955a807 Ratio
BM_SpinLockThrashing/1/process_time/real_time 0.2085113525390625 ms/iter 0.09737838542342582 ms/iter 2.14

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.