Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROMETHEUS_EXPORTER] Fix default for emitting otel_scope attributes #3171

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

yashykt
Copy link
Contributor

@yashykt yashykt commented Nov 26, 2024

Fixes #3170

Changes

Fixes the default behavior of emitting otel_scope attributes.

@yashykt yashykt requested a review from a team as a code owner November 26, 2024 05:02
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 64a58ca
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67455655433cde000824d83a

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.86%. Comparing base (955a807) to head (64a58ca).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3171   +/-   ##
=======================================
  Coverage   87.86%   87.86%           
=======================================
  Files         195      195           
  Lines        6151     6151           
=======================================
  Hits         5404     5404           
  Misses        747      747           

@marcalff
Copy link
Member

From the spec:

A Prometheus Exporter MAY support a configuration option to produce metrics without a scope info metric, or scope labels. The option MAY be named without_scope_info, and MUST be false by default.

so this PR is indeed the expected behavior.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff merged commit 8d45dec into open-telemetry:main Nov 26, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus Exporter: otel_scope attributes not present by default
2 participants